jQuery.effects.define() #288
Conversation
|
I added |
|
Looks good :-) (i.e. no typo) |
|
I added |
|
I added |
|
All looks good :-) |
| </signature> | ||
| <desc>Saves all inline styles applied to an element.</desc> | ||
| <longdesc> | ||
| <p>Saves all inline styles applied to an element. This is useful when animating various styles and restoring the existing styles at the end. The saved styles can be restored using <a href="/jQuery.effects.restoreStyle/"><code>jQuery.effects.restoreStyle()</code></a>.</p> |
There was a problem hiding this comment.
This needs to explain what "save" means here. As far as I can tell it stores a copy of style.cssText via .data(), without making any changes to the styles itself.
Also applies to restoreStyle.
There was a problem hiding this comment.
The how is pure internal details. The only thing the user should care about is how to restore the styles that have been saved, which is documented.
There was a problem hiding this comment.
Its not just internal details. The semantics of the method were unclear to me until I read the code, which makes for bad documentation.
There was a problem hiding this comment.
Can you explain what semantics were unclear?
|
Apart from the underspecified |
|
Updated the wording for |
|
Looks good |
|
Merged into 1-12. |
No description provided.